Phase C: add CTBase.Data submodule (moved from CTFlows)#464
Merged
Conversation
Moves the Data module (VectorField, Hamiltonian, HamiltonianVectorField and their abstract supertypes) from CTFlows into CTBase so it can be shared across the ecosystem. The three construction defaults (__is_autonomous, __is_variable, __is_inplace) are also moved here (Data/default.jl) so CTBase.Data is fully self-contained (depends only on CTBase.Traits and CTBase.Exceptions). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Core → Exceptions → Traits → Data → Descriptions → DevTools → Unicode follows the dependency order rather than a loose alphabetical sort. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace the incorrect julia snippet with a working @example data block that shows the correct out-of-place return values (dx, dp) and (dx, dp, dpv) with variable_costate=true, and the in-place dpv buffer argument that was missing. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Exceptions → Traits → Data → Descriptions matches the dependency order established in index.md and getting-started.md. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Datamodule (VectorField, Hamiltonian, HamiltonianVectorField and their abstract supertypes) from CTFlows into CTBase so it can be shared across the ecosystemData/default.jlwith the three construction defaults (__is_autonomous,__is_variable,__is_inplace) — CTBase.Data is now fully self-contained (depends only onCTBase.TraitsandCTBase.Exceptions)CTBase.DatainCTBase.jlafterTraitstest/suite/data/, 7 files) and documentation (docs/src/guide/data.md, API reference entries)TestOptions→TestDatain the test runner and all test files0.23.0-betaDepends on: #461 (phase B, merged).
Part of the CTFlows → CTBase move project (phase C).
Test plan
test/suite/data/all pass🤖 Generated with Claude Code